Skip to content

fix: move tmpdir for SAA to one that always exists #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: move tmpdir for SAA to one that always exists #1799

wants to merge 1 commit into from

Conversation

tomashley
Copy link
Contributor

Sometimes at boot, saa is very quick to start and begins writing to the /tmp dir, that is then subseqently remounted losing any work

@tomashley tomashley requested review from a team as code owners September 22, 2025 16:17
cynicaljoy
cynicaljoy reviewed Sep 22, 2025
View reviewed changes
Copy link

@cynicaljoy cynicaljoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a permanent disk do we need to worry about SAA temp files usage eating up the disk?

@jfroche
Copy link
Collaborator

jfroche commented Sep 22, 2025 •
edited
Loading

After=systemd-tmpfiles-setup.service would wait for /tmp to be mounted or
using PrivateTmp=yes might help for this as it adds a dependency on systemd-tmpfiles-setup.service and also hardens the service (https://github.com/systemd/systemd/blob/278953167d27731f46fcb56d77807d522d2ad9d2/src/core/unit.c#L1314C64-L1314C94) ?

@tomashley
Copy link
Contributor Author

After=systemd-tmpfiles-setup.service would wait for /tmp to be mounted or using PrivateTmp=yes might help for this as it adds a dependency on systemd-tmpfiles-setup.service and also hardens the service (https://github.com/systemd/systemd/blob/278953167d27731f46fcb56d77807d522d2ad9d2/src/core/unit.c#L1314C64-L1314C94) ?

I've tried both of these options and neither works.
There is already After tmp.mount and this still causes failures when running. It seems that at some point tmp is remounted.

The issue is that saa is wrapping a salt-ssh command that is forked and doesn't respect/cannot operate within the isolation of the systemd tmpdir.

The environment variable here is purposefully being passed down to the salt-ssh process. I would prefer to keep this setting for tmpfiles passed through to salt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynicaljoy cynicaljoy cynicaljoy left review comments

@samrose samrose samrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomashley @jfroche @samrose @cynicaljoy